Add SageMaker Code Editor version mapping to release workflow#103
Merged
Add SageMaker Code Editor version mapping to release workflow#103
Conversation
added 5 commits
December 10, 2025 16:06
…n product.json metadata
azmkercso
approved these changes
Dec 15, 2025
azmkercso
reviewed
Dec 15, 2025
| @@ -0,0 +1,39 @@ | |||
| Index: code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts | |||
Contributor
There was a problem hiding this comment.
Nit: the filename does not match the updated purpose of the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
D356975867
Enhanced the release workflow to support dual versioning by introducing a separate SageMaker Code Editor version alongside the Code Editor version. This allows independent version tracking for SageMaker-specific releases.
Description of Changes
Removed automatic tag-based triggers, now exclusively using workflow_dispatch with input of code-editor version and sagemaker-code-editor version
Added sagemakerCodeEditorVersion field alongside existing codeEditorVersion in product.json in compiled file
Added patches to allow sagemakerCodeEditorVersion to be displayed in about
Testing
Tested locally by:
Creating tag 1.0.6 on branch 1.0
Running workflow with both version inputs: https://github.com/feiyangliu2023/code-editorv2/actions/runs/20133933342
Check artifact uploaded in local release: https://github.com/feiyangliu2023/code-editorv2/releases/tag/1.0.6
Extracting tarballs and verifying both version fields appear correctly in product.json
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.